feat(router): add connector_transaction_id in error_response from connector flows
#2972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai-harsha-vardhan
added
A-core
sai-harsha-vardhan
requested review from
ArjunKarthik,
SanchithHegde and
Narayanbhat166
ArjunKarthik
approved these changes
Nov 24, 2023
Comment on lines
+2795
to
+2797
| #[derive(Debug, Default, Eq, PartialEq, Deserialize, Serialize)] | ||
| pub struct PaymentIntentErrorResponse { | ||
| pub id: String, |
There was a problem hiding this comment.
payment_intent id from stripe
Narayanbhat166
approved these changes
Nov 24, 2023
likhinbopanna
deleted the
add-connector-transaction-id-in-error-response
branch
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
add
connector_transaction_idin error_response from connector flowshave added the
supportfor stripe connectorAdditional Changes
Motivation and Context
How did you test it?
Tested Manually
Failed card payment with stripe connector (4000000000006975), to see error_code, error_message and connector_transaction_id being non null values in payments response
Checklist
cargo +nightly fmt --allcargo clippy